Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[usm] service discovery add bypassed processes #30278

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

yuri-lipnesh
Copy link
Contributor

What does this PR do?

Add more system processes and container engines to the list of ignored processes.

Motivation

Service discovery of system-probe detects non-instrumented processes and reports them to back-end.
Many of such processes are initiated by operating system, the are of no interest and can be ignored.
With this code change the following processes will be excluded from processing

sshd
dhclient
systemd
systemd-resolved
systemd-networkd
datadog-agent
livenessprobe
docker-proxy
cilium-agent
kubelet
containerd
chronyd
local-volume-provisioner

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@yuri-lipnesh yuri-lipnesh added changelog/no-changelog component/system-probe team/usm The USM team team/apm-onboarding qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Oct 18, 2024
@yuri-lipnesh yuri-lipnesh requested a review from a team as a code owner October 18, 2024 15:34
Copy link

Regression Detector

Regression Detector Results

Run ID: b9321ceb-a63b-4908-b6f0-86244542ce20 Metrics dashboard Target profiles

Baseline: b0ca9e6
Comparison: 992e7aa

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
uds_dogstatsd_to_api_cpu % cpu utilization +0.96 [+0.23, +1.69] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.82 [-1.67, +3.31] 1 Logs
idle_all_features memory utilization +0.78 [+0.68, +0.88] 1 Logs bounds checks dashboard
idle memory utilization +0.70 [+0.65, +0.75] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput +0.54 [+0.48, +0.60] 1 Logs
otel_to_otel_logs ingress throughput +0.14 [-0.67, +0.95] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.13 [-0.11, +0.38] 1 Logs
basic_py_check % cpu utilization +0.07 [-2.71, +2.85] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.01 [-0.21, +0.24] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.01 [-0.32, +0.34] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.10, +0.09] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.05 [-0.23, +0.13] 1 Logs
file_tree memory utilization -0.09 [-0.21, +0.04] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.36 [-0.85, +0.13] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46916355 --os-family=ubuntu

Note: This applies to commit 992e7aa

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/apm-onboarding team/usm The USM team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant