Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBPF-592] gpu: add collector interface for NVML metrics #30270

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

gjulianm
Copy link
Contributor

@gjulianm gjulianm commented Oct 18, 2024

What does this PR do?

This PR adds a Collector type that will be the interface to collect metrics from the different NVML subsystems.

Motivation

https://datadoghq.atlassian.net/browse/EBPF-592

There are different APIs that we need to use to collect the metrics from NVML: there are metrics that we get via specific API functions, others that we get via GPM and others via the FieldValues call. This interface will transparently initialize, check support for and execute all subsystem collectors, and generate metrics that will be usable by the agent core check.

Describe how to test/QA your changes

Unit tests provided

Possible Drawbacks / Trade-offs

Additional Notes

Followup PR: #30271

@gjulianm gjulianm self-assigned this Oct 18, 2024
@gjulianm gjulianm added changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Oct 18, 2024
@agent-platform-auto-pr
Copy link
Contributor

agent-platform-auto-pr bot commented Oct 18, 2024

[Fast Unit Tests Report]

On pipeline 46939225 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help

@gjulianm gjulianm marked this pull request as ready for review October 18, 2024 14:54
@gjulianm gjulianm requested a review from a team as a code owner October 18, 2024 14:54
Copy link

cit-pr-commenter bot commented Oct 18, 2024

Regression Detector

Regression Detector Results

Run ID: e9511398-5b65-44b6-a426-2fa559f4e726 Metrics dashboard Target profiles

Baseline: 0eab229
Comparison: 55caeee

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
basic_py_check % cpu utilization +1.28 [-1.55, +4.11] 1 Logs
pycheck_lots_of_tags % cpu utilization +0.90 [-1.58, +3.38] 1 Logs
file_tree memory utilization +0.85 [+0.71, +1.00] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.72 [-0.00, +1.44] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.34 [-0.15, +0.83] 1 Logs
otel_to_otel_logs ingress throughput +0.25 [-0.57, +1.06] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.08 [-0.16, +0.33] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.22, +0.22] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.01 [-0.10, +0.09] 1 Logs
file_to_blackhole_0ms_latency egress throughput -0.01 [-0.34, +0.32] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.05 [-0.23, +0.13] 1 Logs
idle memory utilization -0.21 [-0.28, -0.15] 1 Logs bounds checks dashboard
idle_all_features memory utilization -0.50 [-0.64, -0.36] 1 Logs bounds checks dashboard
tcp_syslog_to_blackhole ingress throughput -0.86 [-0.91, -0.81] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 8/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46939225 --os-family=ubuntu

Note: This applies to commit 55caeee

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant