Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Ignore the SA4023 for staticheck to fix the macOS Gitlab runners linters #30269

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

amenasria
Copy link
Member

@amenasria amenasria commented Oct 18, 2024

What does this PR do?

This PR ignores the SA4023 rule for staticheck to fix the macOS Gitlab runners linters.

Motivation

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

@amenasria amenasria added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-devx-infra labels Oct 18, 2024
@amenasria amenasria requested a review from a team as a code owner October 18, 2024 14:17
@amenasria amenasria changed the title [CI] Ignore the SA4023 for staticheck to fix the macOS Gitlab runners linters [CI] Ignore the SA4023 for staticheck to fix the macOS Gitlab runners linters Oct 18, 2024
Copy link

Regression Detector

Regression Detector Results

Run ID: 1b69615a-3259-424a-b355-1cf153785879 Metrics dashboard Target profiles

Baseline: 7583542
Comparison: 89d267e

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
pycheck_lots_of_tags % cpu utilization +2.30 [-0.24, +4.84] 1 Logs
basic_py_check % cpu utilization +1.59 [-1.26, +4.44] 1 Logs
file_tree memory utilization +1.46 [+1.33, +1.60] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.75 [+0.69, +0.80] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.62 [-0.11, +1.36] 1 Logs
idle memory utilization +0.59 [+0.52, +0.66] 1 Logs bounds checks dashboard
file_to_blackhole_300ms_latency egress throughput +0.03 [-0.16, +0.21] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.02 [-0.31, +0.35] 1 Logs
file_to_blackhole_100ms_latency egress throughput +0.02 [-0.21, +0.24] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput +0.00 [-0.01, +0.01] 1 Logs
uds_dogstatsd_to_api ingress throughput -0.00 [-0.09, +0.08] 1 Logs
file_to_blackhole_500ms_latency egress throughput -0.10 [-0.34, +0.15] 1 Logs
file_to_blackhole_1000ms_latency egress throughput -0.31 [-0.80, +0.17] 1 Logs
otel_to_otel_logs ingress throughput -1.52 [-2.32, -0.73] 1 Logs
idle_all_features memory utilization -3.35 [-3.49, -3.21] 1 Logs bounds checks dashboard

Bounds Checks

perf experiment bounds_check_name replicates_passed
idle memory_usage 9/10
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-devx-infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant