[clusteragent] Remove the CPU/memory limits by default for the init container #30266
+83
−28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
team/container-platform
…configs to set the limits
iamluc
force-pushed
the
luc/clusteragent-ssi-increase-k8s-resources
branch
from
d11f0fb
to
5ea4dd9
Compare
|
[Fast Unit Tests Report] On pipeline 46930637 (CI Visibility). The following jobs did not run any unit tests: Jobs:
If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-devx-help |
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=46930637 --os-family=ubuntuNote: This applies to commit 6fd7387 |
iamluc
changed the title
iamluc
changed the title
iamluc
commented
Oct 18, 2024
| if err != nil { | ||
| return resources, err | ||
| } | ||
| resources.Limits[corev1.ResourceCPU] = quantity |
There was a problem hiding this comment.
Is it OK to not set a limit at all (same for the memory)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Motivation
The current limits are too low for the SSI init container.
We decided to drop them and just keep the "requests".
Also, the current CPU limit (0.05 of a CPU core) is very low. I suggest to use
0.3.Describe how to test/QA your changes
Need help for this: I don't know much about kubernetes 🙈
Possible Drawbacks / Trade-offs
Additional Notes