Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EBPF] GPU-monitoring: added nvml lib path config knob #30263

Merged
merged 4 commits into from
Oct 18, 2024

Conversation

val06
Copy link
Contributor

@val06 val06 commented Oct 18, 2024

What does this PR do?

allows to provide a custom path to libnvml-so native lib path

Motivation

can simplify the deployment in containerized environments and allow side-by-side libnvml-so libs

Describe how to test/QA your changes

Possible Drawbacks / Trade-offs

Additional Notes

Jira ticket

- switched the process scan interval to a config flag with default value
@val06 val06 added changelog/no-changelog team/ebpf-platform qa/done Skip QA week as QA was done before merge and regressions are covered by tests labels Oct 18, 2024
@val06 val06 requested a review from a team as a code owner October 18, 2024 13:21
@val06 val06 changed the title [EBPF] added nvmllibrarypath config knob [EBPF] GPU-monitoring: added nvml lib path config knob Oct 18, 2024
Copy link
Contributor

@gjulianm gjulianm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, only one comment for clarification.

cmd/system-probe/modules/gpu.go Outdated Show resolved Hide resolved
@agent-platform-auto-pr
Copy link
Contributor

Test changes on VM

Use this command from test-infra-definitions to manually test this PR changes on a VM:

inv create-vm --pipeline-id=46916792 --os-family=ubuntu

Note: This applies to commit d09c912

@val06
Copy link
Contributor Author

val06 commented Oct 18, 2024

/merge

@dd-devflow
Copy link

dd-devflow bot commented Oct 18, 2024

🚂 MergeQueue: pull request added to the queue

The median merge time in main is 24m.

Use /merge -c to cancel this operation!

Copy link

Regression Detector

Regression Detector Results

Run ID: 513b98c8-2075-4920-b8f0-ebbe14c7f355 Metrics dashboard Target profiles

Baseline: 7583542
Comparison: d09c912

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI trials links
file_tree memory utilization +2.48 [+2.33, +2.64] 1 Logs
basic_py_check % cpu utilization +1.11 [-1.70, +3.92] 1 Logs
tcp_syslog_to_blackhole ingress throughput +0.41 [+0.36, +0.47] 1 Logs
otel_to_otel_logs ingress throughput +0.22 [-0.59, +1.03] 1 Logs
uds_dogstatsd_to_api_cpu % cpu utilization +0.18 [-0.54, +0.90] 1 Logs
file_to_blackhole_500ms_latency egress throughput +0.12 [-0.12, +0.37] 1 Logs
uds_dogstatsd_to_api ingress throughput +0.01 [-0.09, +0.12] 1 Logs
file_to_blackhole_1000ms_latency egress throughput +0.01 [-0.48, +0.50] 1 Logs
file_to_blackhole_0ms_latency egress throughput +0.00 [-0.33, +0.34] 1 Logs
tcp_dd_logs_filter_exclude ingress throughput -0.00 [-0.01, +0.01] 1 Logs
file_to_blackhole_100ms_latency egress throughput -0.00 [-0.23, +0.22] 1 Logs
file_to_blackhole_300ms_latency egress throughput -0.07 [-0.25, +0.11] 1 Logs
idle_all_features memory utilization -0.45 [-0.60, -0.30] 1 Logs bounds checks dashboard
idle memory utilization -0.67 [-0.73, -0.61] 1 Logs bounds checks dashboard
pycheck_lots_of_tags % cpu utilization -0.97 [-3.48, +1.54] 1 Logs

Bounds Checks

perf experiment bounds_check_name replicates_passed
file_to_blackhole_0ms_latency memory_usage 10/10
file_to_blackhole_1000ms_latency memory_usage 10/10
file_to_blackhole_100ms_latency memory_usage 10/10
file_to_blackhole_300ms_latency memory_usage 10/10
file_to_blackhole_500ms_latency memory_usage 10/10
idle memory_usage 10/10
idle_all_features memory_usage 10/10

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-mergequeue dd-mergequeue bot merged commit 3702bb5 into main Oct 18, 2024
288 of 290 checks passed
@dd-mergequeue dd-mergequeue bot deleted the valeri.pliskin/nvml-library-path-config branch October 18, 2024 15:46
@github-actions github-actions bot added this to the 7.60.0 milestone Oct 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog component/system-probe qa/done Skip QA week as QA was done before merge and regressions are covered by tests team/ebpf-platform
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants