-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CWS] Add missing cgroup write event stringer #30244
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=46914685 --os-family=ubuntu Note: This applies to commit 5348502 |
Regression DetectorRegression Detector ResultsRun ID: 3da6dd1c-4cc7-4093-a7db-2821b1be6b5b Metrics dashboard Target profiles Baseline: b77289c Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
---|---|---|---|---|---|---|
➖ | idle | memory utilization | +0.71 | [+0.66, +0.75] | 1 | Logs bounds checks dashboard |
➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.68 | [-0.06, +1.42] | 1 | Logs |
➖ | tcp_syslog_to_blackhole | ingress throughput | +0.42 | [+0.37, +0.47] | 1 | Logs |
➖ | idle_all_features | memory utilization | +0.37 | [+0.28, +0.47] | 1 | Logs bounds checks dashboard |
➖ | file_to_blackhole_500ms_latency | egress throughput | +0.22 | [-0.02, +0.46] | 1 | Logs |
➖ | file_to_blackhole_1000ms_latency | egress throughput | +0.04 | [-0.44, +0.52] | 1 | Logs |
➖ | file_to_blackhole_100ms_latency | egress throughput | +0.01 | [-0.21, +0.23] | 1 | Logs |
➖ | file_to_blackhole_0ms_latency | egress throughput | +0.00 | [-0.34, +0.34] | 1 | Logs |
➖ | tcp_dd_logs_filter_exclude | ingress throughput | -0.00 | [-0.01, +0.01] | 1 | Logs |
➖ | uds_dogstatsd_to_api | ingress throughput | -0.02 | [-0.10, +0.07] | 1 | Logs |
➖ | file_to_blackhole_300ms_latency | egress throughput | -0.04 | [-0.22, +0.13] | 1 | Logs |
➖ | file_tree | memory utilization | -0.13 | [-0.25, -0.01] | 1 | Logs |
➖ | basic_py_check | % cpu utilization | -0.27 | [-3.00, +2.45] | 1 | Logs |
➖ | otel_to_otel_logs | ingress throughput | -0.34 | [-1.15, +0.47] | 1 | Logs |
➖ | pycheck_lots_of_tags | % cpu utilization | -1.53 | [-4.08, +1.02] | 1 | Logs |
Bounds Checks
perf | experiment | bounds_check_name | replicates_passed |
---|---|---|---|
✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 |
✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
✅ | idle | memory_usage | 10/10 |
✅ | idle_all_features | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
/merge |
🚂 MergeQueue: waiting for PR to be ready This merge request is not mergeable yet, because of pending checks/missing approvals. It will be added to the queue as soon as checks pass and/or get approvals. Use |
🚂 MergeQueue: pull request added to the queue The median merge time in Use |
What does this PR do?
Add missing stringer for cgroup write event
Motivation
Otherwise if we want to add the corresponding probe, system-probe will fail to start.
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes