[ASCII-2410] remove usage of global tagger #30214
Conversation
Test changes on VMUse this command from test-infra-definitions to manually test this PR changes on a VM: inv create-vm --pipeline-id=46902974 --os-family=ubuntuNote: This applies to commit 025f898 |
GustavoCaso
force-pushed
the
remove-usage-of-globaltagger
branch
2 times, most recently
from
1d7f517
to
100ed74
Compare
GustavoCaso
force-pushed
the
remove-usage-of-globaltagger
branch
from
100ed74
to
495eae1
Compare
Regression DetectorRegression Detector ResultsRun ID: ac0e6f9f-bcc9-4bb4-83c3-edd3a6ad7863 Metrics dashboard Target profiles Baseline: 40c637a Performance changes are noted in the perf column of each table:
No significant changes in experiment optimization goalsConfidence level: 90.00% There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.
|
| perf | experiment | goal | Δ mean % | Δ mean % CI | trials | links |
|---|---|---|---|---|---|---|
| ➖ | pycheck_lots_of_tags | % cpu utilization | +1.82 | [-0.71, +4.34] | 1 | Logs |
| ➖ | tcp_syslog_to_blackhole | ingress throughput | +0.41 | [+0.35, +0.46] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api_cpu | % cpu utilization | +0.36 | [-0.35, +1.08] | 1 | Logs |
| ➖ | file_tree | memory utilization | +0.22 | [+0.07, +0.37] | 1 | Logs |
| ➖ | file_to_blackhole_500ms_latency | egress throughput | +0.11 | [-0.15, +0.36] | 1 | Logs |
| ➖ | otel_to_otel_logs | ingress throughput | +0.05 | [-0.76, +0.85] | 1 | Logs |
| ➖ | file_to_blackhole_300ms_latency | egress throughput | +0.00 | [-0.18, +0.18] | 1 | Logs |
| ➖ | uds_dogstatsd_to_api | ingress throughput | +0.00 | [-0.10, +0.10] | 1 | Logs |
| ➖ | tcp_dd_logs_filter_exclude | ingress throughput | +0.00 | [-0.01, +0.01] | 1 | Logs |
| ➖ | file_to_blackhole_0ms_latency | egress throughput | -0.02 | [-0.36, +0.31] | 1 | Logs |
| ➖ | file_to_blackhole_100ms_latency | egress throughput | -0.05 | [-0.27, +0.17] | 1 | Logs |
| ➖ | idle_all_features | memory utilization | -0.06 | [-0.18, +0.05] | 1 | Logs bounds checks dashboard |
| ➖ | file_to_blackhole_1000ms_latency | egress throughput | -0.44 | [-0.93, +0.06] | 1 | Logs |
| ➖ | idle | memory utilization | -0.66 | [-0.70, -0.61] | 1 | Logs bounds checks dashboard |
| ➖ | basic_py_check | % cpu utilization | -1.46 | [-4.17, +1.24] | 1 | Logs |
Bounds Checks
| perf | experiment | bounds_check_name | replicates_passed |
|---|---|---|---|
| ✅ | file_to_blackhole_0ms_latency | memory_usage | 10/10 |
| ✅ | file_to_blackhole_1000ms_latency | memory_usage | 10/10 |
| ✅ | file_to_blackhole_100ms_latency | memory_usage | 10/10 |
| ✅ | file_to_blackhole_300ms_latency | memory_usage | 10/10 |
| ✅ | file_to_blackhole_500ms_latency | memory_usage | 10/10 |
| ✅ | idle | memory_usage | 10/10 |
| ✅ | idle_all_features | memory_usage | 10/10 |
Explanation
A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".
For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:
-
Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.
-
Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.
-
Its configuration does not mark it "erratic".
GustavoCaso
changed the title
GustavoCaso
changed the title
Go Package Import DifferencesBaseline: b77289c
|
GustavoCaso
force-pushed
the
remove-usage-of-globaltagger
branch
from
1ec650d
to
fc852cb
Compare
Serverless Benchmark Results
tl;drUse these benchmarks as an insight tool during development.
What is this benchmarking?The The benchmark is run using a large variety of lambda request payloads. In the charts below, there is one row for each event payload type. How do I interpret these charts?The charts below comes from The benchstat docs explain how to interpret these charts.
I need more helpFirst off, do not worry if the benchmarks are failing. They are not tests. The intention is for them to be a tool for you to use during development. If you would like a hand interpreting the results come chat with us in Benchmark stats |
What does this PR do?
Motivation
Describe how to test/QA your changes
Possible Drawbacks / Trade-offs
Additional Notes