[NDM] Fix for ignored_ip_addresses in autodiscovery #30180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
community
team/container-platform
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds fix and unit test for a bug that currently exists in the NDM Autodiscovery Listener.
Motivation
When adding ignored_ip_addresses to the NDM Autodiscovery config in datadog.yaml, the SNMP Listener fails to start and no error is logged.
Describe how to test/QA your changes
Unit test included in PR
Possible Drawbacks / Trade-offs
None
Additional Notes
Related issue: #30181
Unit test showing original unmarshal bug: #30177