Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable omnibus cache on Windows #24850

Closed
wants to merge 2 commits into from

Conversation

chouquette
Copy link
Contributor

What does this PR do?

This fixes iterating over the cache tags on windows, and re-enables the cache since the root cause for the initial failure is fixed.

Motivation

Additional Notes

Possible Drawbacks / Trade-offs

Describe how to test/QA your changes

@chouquette chouquette added changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-build-and-releases BaRX labels Apr 19, 2024
@chouquette chouquette requested review from a team as code owners April 19, 2024 09:23
@agent-platform-auto-pr
Copy link
Contributor

[Fast Unit Tests Report]

On pipeline 32480534 (CI Visibility). The following jobs did not run any unit tests:

Jobs:
  • tests_deb-arm64-py3
  • tests_deb-x64-py3
  • tests_flavor_dogstatsd_deb-x64
  • tests_flavor_heroku_deb-x64
  • tests_flavor_iot_deb-x64
  • tests_rpm-arm64-py3
  • tests_rpm-x64-py3
  • tests_windows-x64

If you modified Go files and expected unit tests to run in these jobs, please double check the job logs. If you think tests should have been executed reach out to #agent-developer-experience

@pr-commenter
Copy link

pr-commenter bot commented Apr 19, 2024

Regression Detector

Regression Detector Results

Run ID: 91b918b1-8290-469b-895d-26097fc34cab
Baseline: 1e87620
Comparison: 2294538

Performance changes are noted in the perf column of each table:

  • ✅ = significantly better comparison variant performance
  • ❌ = significantly worse comparison variant performance
  • ➖ = no significant change in performance

No significant changes in experiment optimization goals

Confidence level: 90.00%
Effect size tolerance: |Δ mean %| ≥ 5.00%

There were no significant changes in experiment optimization goals at this confidence level and effect size tolerance.

Experiments ignored for regressions

Regressions in experiments with settings containing erratic: true are ignored.

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.46 [-3.84, +6.76]

Fine details of change detection per experiment

perf experiment goal Δ mean % Δ mean % CI
file_to_blackhole % cpu utilization +1.46 [-3.84, +6.76]
uds_dogstatsd_to_api_cpu % cpu utilization +0.52 [-2.50, +3.54]
file_tree memory utilization +0.30 [+0.18, +0.41]
process_agent_standard_check memory utilization +0.28 [+0.22, +0.34]
otel_to_otel_logs ingress throughput +0.25 [-0.18, +0.69]
process_agent_standard_check_with_stats memory utilization +0.15 [+0.11, +0.20]
tcp_dd_logs_filter_exclude ingress throughput +0.01 [-0.01, +0.03]
trace_agent_msgpack ingress throughput +0.00 [-0.02, +0.02]
uds_dogstatsd_to_api ingress throughput +0.00 [-0.20, +0.20]
trace_agent_json ingress throughput -0.02 [-0.04, +0.00]
tcp_syslog_to_blackhole ingress throughput -0.15 [-0.23, -0.07]
idle memory utilization -0.39 [-0.43, -0.35]
process_agent_real_time_mode memory utilization -0.71 [-0.76, -0.66]
basic_py_check % cpu utilization -1.12 [-3.73, +1.50]
pycheck_1000_100byte_tags % cpu utilization -1.46 [-6.35, +3.42]

Explanation

A regression test is an A/B test of target performance in a repeatable rig, where "performance" is measured as "comparison variant minus baseline variant" for an optimization goal (e.g., ingress throughput). Due to intrinsic variability in measuring that goal, we can only estimate its mean value for each experiment; we report uncertainty in that value as a 90.00% confidence interval denoted "Δ mean % CI".

For each experiment, we decide whether a change in performance is a "regression" -- a change worth investigating further -- if all of the following criteria are true:

  1. Its estimated |Δ mean %| ≥ 5.00%, indicating the change is big enough to merit a closer look.

  2. Its 90.00% confidence interval "Δ mean % CI" does not contain zero, indicating that if our statistical model is accurate, there is at least a 90.00% chance there is a difference in performance between baseline and comparison variants.

  3. Its configuration does not mark it "erratic".

@dd-devflow dd-devflow bot closed this Oct 19, 2024
@dd-devflow dd-devflow bot deleted the chouquette/reenable_omnibus_cache_windows branch October 19, 2024 00:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog/no-changelog qa/no-code-change Skip QA week as there is no code change in Agent code team/agent-build-and-releases BaRX
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant