Revert Handle errors in python subprocess cmd.Start() (#30264)

(cherry picked from commit 463727b)
DataDog · Oct 18, 2024 · 47f0ce2 · 47f0ce2
1 parent 76f7ed4
commit 47f0ce2
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 6 deletions.
diff --git a/pkg/collector/python/test_util.go b/pkg/collector/python/test_util.go
@@ -59,7 +59,7 @@ func testGetSubprocessOutputUnknownBin(t *testing.T) {
 	assert.Equal(t, "", C.GoString(cStdout))
 	assert.Equal(t, "", C.GoString(cStderr))
 	assert.Equal(t, C.int(0), cRetCode)
-	assert.NotNil(t, exception)
+	assert.Nil(t, exception)
 }
 
 func testGetSubprocessOutputError(t *testing.T) {

diff --git a/pkg/collector/python/util.go b/pkg/collector/python/util.go
@@ -68,11 +68,7 @@ func GetSubprocessOutput(argv **C.char, env **C.char, cStdout **C.char, cStderr
 		outputErr, _ = io.ReadAll(stderr)
 	}()
 
-	err = cmd.Start()
-	if err != nil {
-		*exception = TrackedCString(fmt.Sprintf("internal error starting subprocess: %v", err))
-		return
-	}
+	cmd.Start() //nolint:errcheck
 
 	// Wait for the pipes to be closed *before* waiting for the cmd to exit, as per os.exec docs
 	wg.Wait()