Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes - Group filters #31

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Bug fixes - Group filters #31

merged 2 commits into from
Nov 6, 2023

Conversation

TalMalka123
Copy link
Contributor

  • Make the filter's onChange prop not mandatory.
  • In case an onChange function is passed, invoke it (it has not been invoked by now).
  • Fix showAll toggle value, when manually toggling all filters on/off.

@TalMalka123
make filter onChange prop not mandatory; In case an onChange func pas…
0996712 
…sed, invoke it; Fix showAll toggle value, when manually toggling all filters on/off
@TalMalka123 TalMalka123 self-assigned this Oct 25, 2023
@TalMalka123 TalMalka123 merged commit 84e9585 into main Nov 6, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@guysmoilov guysmoilov guysmoilov approved these changes

@simonlsk simonlsk Awaiting requested review from simonlsk

Assignees

@TalMalka123 TalMalka123

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TalMalka123 @guysmoilov