feature | add support of custom no result message #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonlsk
approved these changes
Jul 13, 2023
| @@ -23,6 +30,7 @@ export const FileTree = ({ list, loading, getFilesCb, onSelect }: FileTreeInterf | |||
| } | |||
| }; | |||
|
|
|||
| console.log('emptyMessage', emptyMessage); | |||
There was a problem hiding this comment.
i didnt pushed my last commit ):
| @@ -59,6 +59,7 @@ FileTreeWithFiles.args = { | |||
| href: '/' | |||
| } | |||
| ], | |||
| emptyMessage: 'empty message ', | |||
There was a problem hiding this comment.
You can write a real message like "no files here" no?
| @@ -29,7 +30,8 @@ export function FileTreeItem({ | |||
| getFilesCb, | |||
| setSelected, | |||
| type, | |||
| href | |||
| href, | |||
| emptyMessage, | |||
| if (emptyMessage) { | ||
| return <Box ml={2} p={1}>{emptyMessage}</Box>; | ||
| } | ||
| // fallback | ||
| return <Box p={1}>This file is empty</Box>; |
There was a problem hiding this comment.
This should be "This directory is empty"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for empty or nonrelevant files today we render the same message of "no files".
now, we support custom message for empty children result but we can differentiate when there's no files and no relevant dir or bucket and existing files but nothing relevant to display
case 1: 0 files display "no files"
case 2: some files but not dir or bucket so we would display a custom message about it.