Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API 5 changes #132

Merged
merged 8 commits into from
Jul 16, 2023
Merged

API 5 changes #132

merged 8 commits into from
Jul 16, 2023

Conversation

jasonw4331
Copy link
Contributor

@jasonw4331 jasonw4331 commented Jun 10, 2023

Please make sure your pull request complies with these guidelines:

    • Use same formatting
    • Changes must have been tested on PMMP.
    • Unless it is a minor code modification, you must use an IDE.
    • Have a detailed title.

What does the PR change?

Support for PocketMine API 5
Minor version bump
FormAPI Dependency change to LTS alternative
Re-enable poggit Lint

Testing Environment

  • PHP: 8.1
  • PMMP: 5.0
  • OS: Windows

Extra Information

Commando, libPiggyUpdateChecker, and libPiggyEconomy need an API 5 build on poggit to build PiggyFactions

@Aericio Aericio self-requested a review June 12, 2023 03:36
@Aericio Aericio self-assigned this Jun 12, 2023
@Aericio Aericio removed their request for review June 12, 2023 03:36
@jasonw4331
Copy link
Contributor Author

jasonw4331 commented Jun 12, 2023

Waiting on the following PR merges:
Paroxity/Commando#9
DaPigGuy/libPiggyUpdateChecker#2

libPiggyEconomy requires some extra work because only BedrockEconomy is being updated to work on API 5 to date

@Aericio Aericio self-requested a review July 16, 2023 00:18
@Aericio Aericio merged commit 5ab2604 into DaPigGuy:master Jul 16, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants