Skip to content

Commit

Permalink
handle lowercase nhdplusid fixes #393
Browse files Browse the repository at this point in the history
  • Loading branch information
@dblodgett-usgs
dblodgett-usgs committed Jul 20, 2024
1 parent e80be3b commit 78829da
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion DESCRIPTION
View file
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
Package: nhdplusTools
Type: Package
Title: NHDPlus Tools
Version: 1.2.1
Version: 1.2.2
Authors@R: c(person(given = "David",
family = "Blodgett",
role = c("aut", "cre"),
Expand Down
2 changes: 1 addition & 1 deletion R/A_nhdplusTools.R
View file
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ WBAREACOMI <- "WBAREACOMI"

# List of input names that should be changed to replacement names
nhdplus_attributes <- list(
COMID = COMID, NHDPlusID = COMID,
COMID = COMID, NHDPlusID = COMID, nhdplusid = COMID,
Permanent_Identifier = Permanent_Identifier,
RPUID = RPUID,
VPUID = VPUID,
Expand Down

2 comments on commit 78829da

@mkoohafkan
Copy link

@mkoohafkan mkoohafkan commented on 78829da Jul 20, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also just uppercase all the attributes of the input and then do the name substitutions, that way you don't have to account for every permutation of e.g. NhDpLuSiD.

@dblodgett-usgs
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah... that's how it works in hydroloom now but not the way it's done in nhdplusTools unfortunately. This is just a quick patch for this corner case where nhdplushr uses inconsistent case for some attributes.

Please sign in to comment.