Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up comparison notebooks and fix vis.py #133

Merged
merged 3 commits into from
May 22, 2024

Conversation

amystamile-usgs
Copy link
Contributor

When cleaning up the comparison notebooks, incorporating the newer ALE implementation essentially standardized the code across all the comparison notebooks. Therefore, I decided it would be more efficient to maintain a single comparison notebook.

closes #108, closes #92, closes #123

I also noticed that vis.py dependencies were not being shipped in the knoten releases (kalasiris and plotly).

Licensing

This project is mostly composed of free and unencumbered software released into the public domain, and we are unlikely to accept contributions that are not also released into the public domain. Somewhere near the top of each file should have these words:

This work is free and unencumbered software released into the public domain. In jurisdictions that recognize copyright laws, the author or authors of this software dedicate any and all copyright interest in the software to the public domain.

  • I dedicate any and all copyright interest in this software to the public domain. I make this dedication for the benefit of the public at large and to the detriment of my heirs and successors. I intend this dedication to be an overt act of relinquishment in perpetuity of all present and future rights to this software under copyright law.

Copy link
Collaborator

@jlaura jlaura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - do you want to strip the output cells from the notebooks? Then the notebook won't have those big binary blobs. The downside is that someone has to run the notebook to see the visualization output. Whatever is cool here!

@jlaura
Copy link
Collaborator

jlaura commented May 22, 2024

Ohh also, kalasiris dependency - can that be optional? Honestly, can all of the vis stuff be optional? For someone not wanting to do a comparison, they are bloat in a CSM library.

@amystamile-usgs
Copy link
Contributor Author

Ohh also, kalasiris dependency - can that be optional? Honestly, can all of the vis stuff be optional? For someone not wanting to do a comparison, they are bloat in a CSM library.

Maybe not including vis.py dependencies was intentional. I think it would be a good idea not to ship kalasiris with knoten. I can just add instructions to install it in the notebook.

@jlaura
Copy link
Collaborator

jlaura commented May 22, 2024

LGTM!

@amystamile-usgs amystamile-usgs merged commit 459231a into DOI-USGS:main May 22, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CI, Python Versioning, and ISIS knoten does not ship vis
2 participants