Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] 6주차 과제 제출 #8

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[feat] 6주차 과제 제출 #8

wants to merge 1 commit into from

Conversation

mikekks
Copy link
Contributor

@mikekks mikekks commented Dec 8, 2023

✒️ 관련 이슈번호 ✒️

💡 과제 내용 및 배운 점 💡

  1. jwt, 쿠키 세션을 들어보기만 했지 실제 구현해본 적은 없었는데 이렇게 구현해봐서 좋았습니다!
  2. 스프링 시큐리티의 전체 과정이 알고있던 'chain of responsibility' 패턴과 비슷한 부분이 많더군요! 실제로도 같은 구조고요! 그래서 구조에 대해서 좀 더 잘 이해가 되었습니다!
  3. Presigned URL 부분이 흥미로워서 구현을 해보고 싶었지만.. 구현하지 못한게 아쉽습니다.. 조만간 구현해보고 싶습니다!

📢 To Reviewers 📢

기본 과제만 했고,, 많은 생각을 못했습니다,, 반성하겠습니다,,

Copy link

@sohyundoh sohyundoh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다 :>
나중에 기회되실 때 MemberService에서 직접 토큰을 발급하는 것을 구현하고 그 토큰을 이용해서 헤더에 담아 API 요청을 보내보시면 좋을 것 같아요!
시험 기간 화이팅!

public void deleteByIdV2(Long postId) {
try {
Post post = postJpaRepository.findById(postId)
.orElseThrow(() -> new BusinessException("해당하는 게시글이 없습니다."));

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1
시간 되실 때 캐치 예외로 나중에 변경하시면 좋을 것 같아요! :->

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

리뷰 감사합니다~!!

Copy link
Member

@jun02160 jun02160 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다 ~~ 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants