-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return ResetRequired
for certificate retrieval
#2870
base: main
Are you sure you want to change the base?
Conversation
@rw8896 to review. Note that this reset mask should be sticky between
|
@@ -3078,6 +3078,8 @@ void libspdm_reset_context(void *spdm_context) | |||
context->mut_auth_cert_chain_buffer_size = 0; | |||
context->current_dhe_session_count = 0; | |||
context->current_psk_session_count = 0; | |||
|
|||
context->local_context.cert_slot_reset_mask = 0; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should not reset cert_slot_reset_mask as you mentioned " reset mask should be sticky between GET_VERSIONS"?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah forgot to delete that. Thanks.
If a SET_CERTIFICATE request results in ResetRequired then subsequent GET_CERTIFICATE requests for that slot, and GET_DIGESTS, should result in ResetRequired. Signed-off-by: Steven Bellock <[email protected]>
b5bfb95
to
7ce6196
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! It looks good to me.
If a
SET_CERTIFICATE
request results inResetRequired
then subsequentGET_CERTIFICATE
requests for that slot, andGET_DIGESTS
, should result inResetRequired
.Signed-off-by: Steven Bellock [email protected]