Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CMakeLists.txt: Allow disabling EDDSA support from command line #2330

Merged
merged 1 commit into from
Sep 18, 2023
Merged

CMakeLists.txt: Allow disabling EDDSA support from command line #2330

merged 1 commit into from
Sep 18, 2023

Conversation

alistair23
Copy link
Contributor

No description provided.

@alistair23
Copy link
Contributor Author

The Windows failures are unrelated to this PR

@steven-bellock
Copy link
Contributor

You can define macros from the command line like

cmake -E env CFLAGS="-DLIBSPDM_FIPS_MODE=1" cmake -DARCH=x64 -DTOOLCHAIN=GCC -DTARGET=Debug -DCRYPTO=mbedtls -DGCOV=ON ..

@alistair23
Copy link
Contributor Author

That can be difficult to do when using build environments or packaging systems. Having a nicely defined argument makes it easier to disable these

@steven-bellock
Copy link
Contributor

That can be difficult to do when using build environments or packaging systems. Having a nicely defined argument makes it easier to disable these

Why single out EDDSA though? Presumably this type of fix would be needed for all macros.

@alistair23
Copy link
Contributor Author

Because the EDDSA support is currently not very good

@jyao1
Copy link
Member

jyao1 commented Sep 13, 2023

I don't have strong opinion. I am OK either way.

@jyao1 jyao1 merged commit 102557f into DMTF:main Sep 18, 2023
90 of 176 checks passed
@alistair23 alistair23 deleted the alistair/crypto-fixup branch September 19, 2023 00:10
@steven-bellock steven-bellock mentioned this pull request Sep 27, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steven-bellock steven-bellock steven-bellock approved these changes

@twilfredo twilfredo twilfredo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@alistair23 @steven-bellock @jyao1 @twilfredo