problem_format: add C++ templates #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we make sure the templates pass |
|
Yes, I'd be happy to add CI for that. Would you also like me to add some tests for the methods using |
Sure, but at least make sure they build or something. |
kiritofeng
reviewed
Jan 8, 2024
Riolku
force-pushed
the
cpp-templates
branch
2 times, most recently
from
03b9a4b
to
76ec663
Compare
Riolku
force-pushed
the
cpp-templates
branch
10 times, most recently
from
24cee83
to
efffd68
Compare
kiritofeng
reviewed
Sep 8, 2024
sample_files/problem_setting/test/testsuite/esoteric_validator/cases/noeol/input
Show resolved
Hide resolved
Riolku
force-pushed
the
cpp-templates
branch
2 times, most recently
from
8fcb74a
to
62f93d3
Compare
Many templates have been floating around in the DMOJ community for validation and input handling in checkers. This commit aims to consolidate them. It has two main goals: - Correct. Duh. - Simple. Other templates that circulate, including the ones I have published, are too complex. People naively try and write their own. I am sick and tired of reading over incorrect validators. These templates forgo some principles of good design (such as object-oriented programming) in favour of pure simplicity. They should be simple enough that they are understandable by the broader community, and are not a black box. Hopefully this also dissuades re-writing.
Riolku
force-pushed
the
cpp-templates
branch
from
62f93d3
to
195ee98
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many templates have been floating around in the DMOJ community for validation and input handling in checkers. This commit aims to consolidate them. It has two main goals:
Correct. Duh.
Simple. Other templates that circulate, including the ones I have published, are too complex. People naively try and write their own. I am sick and tired of reading over incorrect validators.
These templates forgo some principles of good design (such as object-oriented programming) in favour of pure simplicity. They should be simple enough that they are understandable by the broader community, and are not a black box. Hopefully this also dissuades re-writing.