Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.10.2] fix importer and add unit tests #518

Open
wants to merge 24 commits into
base: release-0.11
Choose a base branch
from

Conversation

Severino
Copy link
Contributor

@Severino Severino commented Oct 14, 2024

  • Importer now automatically removes BOM if present
  • Better readable format for error message on validation
  • Renamed fromImport to parseImport on the attribute classses. The base class now by default imports the passed string, removing redundancies on the string-based classes.
  • More elaborate type checking on attributes parseImport method.
  • Unit test for all attribute imports (except Table due to complexity)

Run all tests using php artisan test .\tests\Unit\Attributes

@Severino Severino changed the title 0.10 fix importer and add unit tests [0.10.2] fix importer and add unit tests Oct 14, 2024
@v1r0x v1r0x changed the base branch from master to release-0.11 October 14, 2024 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant