New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor improvement #61

Merged

RadWolfie merged 5 commits into Cxbx-Reloaded:master from RadWolfie:minor-improvement

Apr 25, 2019

Member

RadWolfie commented Mar 21, 2019 •

edited

Loading

Fixed OV_BYTE bug since only value is acceptable for 1 byte size.
- However, current codebase isn't using the OV_ENTRY macro.
- Current codebase will eventually replace default OV entries to macro usage.
Rename OOVPA_TABLE_COUNT to XBSDB_ARRAY_SIZE

Plus a new macro, OV_MATCH, for ability to insert multiple values in one line instead of multiple lines.

Image proof of above image expands to:

JayFoxRox reviewed

View reviewed changes

OOVPA.h Outdated Show resolved Hide resolved

JayFoxRox reviewed

View reviewed changes

OOVPA.h Show resolved Hide resolved

JayFoxRox reviewed

View reviewed changes

OOVPA.h Outdated Show resolved Hide resolved

JayFoxRox reviewed

View reviewed changes

OOVPA.h Outdated Show resolved Hide resolved

JayFoxRox reviewed

View reviewed changes

OOVPA.h Outdated Show resolved Hide resolved

JayFoxRox reviewed

View reviewed changes

OOVPA.h Outdated Show resolved Hide resolved

RadWolfie force-pushed the minor-improvement branch from 76bd73a to 59f0864 Compare

March 21, 2019 17:44


          prevent accidentical input higher than byte size

5a555b2

RadWolfie force-pushed the minor-improvement branch from 59f0864 to c9d6312 Compare

March 21, 2019 22:39

RadWolfie added 4 commits

April 15, 2019 19:03


          add macro for multiple byte values in one line of code

a35d752

Requested by other developer


          remove old note no longer apply to current situation

77edc1b


          change OOVPA_TABLE_COUNT to XBSDB_ARRAY_SIZE

22a1627


          clean up the comment to exclude field type

9d58008

Thanks to PatrickvL for finding it!

RadWolfie force-pushed the minor-improvement branch from c9d6312 to 9d58008 Compare

April 16, 2019 00:07

Member Author

RadWolfie commented Apr 25, 2019

Merging as is.

RadWolfie merged commit c89ee86 into Cxbx-Reloaded:master

RadWolfie deleted the minor-improvement branch

April 25, 2019 01:32

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet