Take volume snapshot after full backup #3970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony-landreth
approved these changes
Aug 19, 2024
dsessler7
force-pushed
the
clone_from_snapshot
branch
from
6204e22
to
695e0df
Compare
cbandy
approved these changes
Aug 21, 2024
| @@ -9,6 +9,9 @@ PGMONITOR_DIR ?= hack/tools/pgmonitor | |||
| PGMONITOR_VERSION ?= v4.11.0 | |||
| QUERIES_CONFIG_DIR ?= hack/tools/queries | |||
|
|
|||
| EXTERNAL_SNAPSHOTTER_DIR ?= hack/tools/external-snapshotter | |||
| EXTERNAL_SNAPSHOTTER_VERSION ?= v8.0.1 | |||
There was a problem hiding this comment.
🤔 Interesting. go get pulls v8.0.0 because of the client/v8.0.0 tag here.
I wonder if we can somehow use the downloaded Go module for this.
There was a problem hiding this comment.
I see that CRDs are downloaded with the Go module:
$ go list -f '{{.Dir}}' -m all | grep external
~/go/pkg/mod/github.com/kubernetes-csi/external-snapshotter/client/[email protected]
$ ls -1 ~/go/pkg/mod/github.com/kubernetes-csi/external-snapshotter/client/[email protected]/config/crd/
groupsnapshot.storage.k8s.io_volumegroupsnapshotclasses.yaml
groupsnapshot.storage.k8s.io_volumegroupsnapshotcontents.yaml
groupsnapshot.storage.k8s.io_volumegroupsnapshots.yaml
kustomization.yaml
snapshot.storage.k8s.io_volumesnapshotclasses.yaml
snapshot.storage.k8s.io_volumesnapshotcontents.yaml
snapshot.storage.k8s.io_volumesnapshots.yamlBut, I don't see module information during tests, very likely because of https://www.github.com/golang/go/issues/33976.
info, ok := debug.ReadBuildInfo()
assert.Assert(t, ok)
t.Logf("%#v", info)test.go:14: &debug.BuildInfo{GoVersion:"go1.22.4", Path:"", Main:debug.Module{Path:"", Version:"", Sum:"", Replace:(*debug.Module)(nil)}, Deps:[]*debug.Module(nil), Settings:[]debug.BuildSetting(nil)}
| @@ -270,6 +273,7 @@ func PGBackRestCronJobLabels(clusterName, repoName, backupType string) labels.Se | |||
| cronJobLabels := map[string]string{ | |||
| LabelPGBackRestRepo: repoName, | |||
| LabelPGBackRestCronJob: backupType, | |||
| LabelPGBackRestBackup: string(BackupScheduled), | |||
Comment on lines
+244
to
+246
| for _, job := range jobs.Items { | ||
| if job.Status.Succeeded > 0 && | ||
| latestCompleteBackupJob.Status.CompletionTime.Before(job.Status.CompletionTime) { |
There was a problem hiding this comment.
🌱 This almost looks like an opportunity for something in slices, slices.MinFunc, maybe? 🤔 I'm not certain the following is any more legible...
untested:
if len(jobs.Items) == 0 {
return nil
}
job := slices.MinFunc(jobs.Items, func(a, b batchv1.Job) int {
if a.Succeeded < 1 {
return 1
}
if b.Succeeded < 1 {
return -1
}
return a.Status.CompletionTime.Compare(b.Status.CompletionTime)
})
if job.Succeeded < 1 {
return nil
}
return &job…a volume after a every backup. Manage snapshots so that only one ReadyToUse snapshot is kept. Add/adjust tests for volume snapshots feature. Add volume snapshot crds directory to envtest environment setup.
dsessler7
force-pushed
the
clone_from_snapshot
branch
from
695e0df
to
d6dfabf
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist:
Type of Changes:
What is the current behavior (link to any open issues here)?
We currently do not have any volume snapshot capability.
What is the new behavior (if this is a feature change)?
If the feature is turned on, both via feature gate and postgrescluster spec, the operator will now take a volume snapshot of the primary pgdata volume after a full backup completes. The operator will keep one ReadyToUse snapshot around, deleting older snapshots.
Other Information: