[MPDX-8405] Fix filtering the map by selected contacts #1154
+144
−195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview branch generated at https://8405-filter-map.d3dytjb8adxkk5.amplifyapp.com |
canac
commented
Oct 23, 2024
| useUserPreference({ | ||
| key: 'contacts_view', | ||
| defaultValue: TableViewModeEnum.List, | ||
| }); | ||
| useEffect(() => { | ||
| if (contactsView && !userOptionsLoading) { | ||
| if (contactsView) { |
There was a problem hiding this comment.
@dr-bizz When I asked you to add this additional check, I was mistaken. I thought this effect saved the user preference, but it is just updating the view mode in the contacts wrapper. It was right how you had it first, so I'm switching it back.
Bundle sizes [mpdx-react]Compared against 9f1e8f2
|
dr-bizz
reviewed
Oct 23, 2024
dr-bizz
reviewed
Oct 25, 2024
pages/accountLists/[accountListId]/contacts/ContactsWrapper.tsx
Outdated
Show resolved
Hide resolved
dr-bizz
approved these changes
Oct 25, 2024
| updateOptions(view as TableViewModeEnum); | ||
| const newViewMode = view as TableViewModeEnum; | ||
| saveContactsView(newViewMode); | ||
| if (newViewMode === TableViewModeEnum.Map && ids.length > 0) { |
There was a problem hiding this comment.
Suggested change
| if (newViewMode === TableViewModeEnum.Map && ids.length > 0) { | |
| if (newViewMode === TableViewModeEnum.Map && ids.length) { |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ContactsContexttests to use a reusable wrapper.Testing
MPDX-8405
Checklist: