Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2290 Support a pagecollection page type #1662

Merged
merged 4 commits into from
Oct 24, 2024
Merged

GT-2290 Support a pagecollection page type #1662

merged 4 commits into from
Oct 24, 2024

Conversation

frett
Copy link
Contributor

@frett frett commented Oct 15, 2024

new XML:

page collection page

<page xmlns="https://mobile-content-api.cru.org/xmlns/page"
    xmlns:analytics="https://mobile-content-api.cru.org/xmlns/analytics"
    xmlns:content="https://mobile-content-api.cru.org/xmlns/content"
    xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" xsi:type="page-collection" id="RG_page_collection">
    <analytics:events>
        <analytics:event action="test" system="firebase" />
    </analytics:events>
    <pages>
        <import filename="Gifts01.json" />
        <import filename="Gifts02.json" />
        <import filename="Gifts03.json" />
        <page xsi:type="content" id="embedded_page">
            <analytics:events>
                <analytics:event action="test" system="firebase" />
            </analytics:events>
            <content>
                <content:spacer />
                <content:paragraph>
                    <content:text>Text</content:text>
                </content:paragraph>
            </content>
        </page>
        <import filename="Gifts04.json" />
        <import filename="Gifts05.json" />
        <import filename="Gifts06.json" />
        <import filename="Gifts07.json" />
    </pages>
</page>

page parent updates

<!-- long term how parent pages can be specified to deep link to a specific page in a page collection -->
<page cyoa:parent="RG_page_collection?active-page=RG03" />

<!-- For backwards compatibility while we need to support older versions of the app that don't support page collections -->
<page cyoa:parent="RG03" cyoa:parent_override_page-collection="RG_page_collection?active-page=RG03" />

@frett frett force-pushed the specPageCollection branch 2 times, most recently from 071a410 to 4400093 Compare October 22, 2024 16:52
@frett frett force-pushed the specPageCollection branch 4 times, most recently from 619c55f to 3f7a85c Compare October 24, 2024 14:30
@frett frett marked this pull request as ready for review October 24, 2024 16:37
@frett frett enabled auto-merge October 24, 2024 16:48
@frett frett merged commit 2744fc8 into master Oct 24, 2024
10 checks passed
@frett frett deleted the specPageCollection branch October 24, 2024 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants