Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GT-2450 Add support for PageCollectionPages in CYOA tools #700

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

add a constant for the active-page parent parameter

7311a03
Select commit
Loading
Failed to load commit list.
Open

GT-2450 Add support for PageCollectionPages in CYOA tools #700

add a constant for the active-page parent parameter
7311a03
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Oct 24, 2024 in 1s

86.01% (-0.14%) compared to 5b3acbb

View this Pull Request on Codecov

86.01% (-0.14%) compared to 5b3acbb

Details

Codecov Report

Attention: Patch coverage is 86.84211% with 15 lines in your changes missing coverage. Please review.

Project coverage is 86.01%. Comparing base (5b3acbb) to head (7311a03).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...hared/tool/parser/model/page/PageCollectionPage.kt 83.33% 1 Missing and 6 partials ⚠️
.../cru/godtools/shared/tool/parser/model/Manifest.kt 90.32% 1 Missing and 2 partials ⚠️
...cru/godtools/shared/tool/parser/model/page/Page.kt 90.90% 0 Missing and 3 partials ⚠️
.../cru/godtools/shared/tool/parser/model/HasPages.kt 33.33% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main     #700      +/-   ##
==========================================
- Coverage   86.15%   86.01%   -0.14%     
==========================================
  Files          93       95       +2     
  Lines        2260     2331      +71     
  Branches      529      550      +21     
==========================================
+ Hits         1947     2005      +58     
- Misses        123      126       +3     
- Partials      190      200      +10

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov