Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GT-2440 - Change Prev/Next Buttons to A tags #156

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Sep 13, 2024

Description

When embedded, Google doesn't pick up button clicks, so in this PR, I change the buttons that lead to a page change to A tags with a href="javascript:void(0)" attribute.

Copy link
Contributor

@caleballdrin caleballdrin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@dr-bizz dr-bizz added the On Staging Will be merged to the staging branch by Github Actions label Sep 13, 2024
Copy link
Contributor

I see you added the "On Staging" label, I'll get this merged to the staging branch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants