Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HS-1132003] Upgrade rollbar #853

Merged
merged 3 commits into from
Apr 5, 2024
Merged

[HS-1132003] Upgrade rollbar #853

merged 3 commits into from
Apr 5, 2024

Conversation

canac
Copy link
Contributor

@canac canac commented Apr 5, 2024

Upgrade rollbar to get additional telemetry such as network activity like give-web has. Here's an example of an occurrence in staging. Please double-check that all PII is removed.

Assisting with debugging https://secure.helpscout.net/conversation/2560557180/1132003?viewId=320673

@canac canac added the On Staging Will be merged to the staging branch by Github Actions label Apr 5, 2024
@canac
Copy link
Contributor Author

canac commented Apr 5, 2024

The credit card form input values were still being recorded as DOM interactions. All input values are now scrubbed. New occurrence with input scrubbing enabled: https://app.rollbar.com/a/Cru/fix/item/ert-web/795/occurrence/402830618045#detail. We could make the scrubbing more granular in the future if desired.

@canac canac merged commit 91c26d5 into master Apr 5, 2024
14 checks passed
@canac canac deleted the upgrade-rollbar branch April 5, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants