-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
No-Jira Fix Campus #847
No-Jira Fix Campus #847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One stray comment, but it looks great! Good work with the tests too.
Unless it's on purpose, you probably want to revert all your changes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dr-bizz I haven't pushed it to staging yet. The On Staging label doesn't work for the ERT. I'm not sure why. It would be nice if it did. |
@dr-bizz It is on staging now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just tested it again and this is still happening
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's one more tweak we should make to the test. I think that if you use my suggestion, lines 257-258 will be hit by code coverage. We also might need a test with a non-empty campus answer in validateRegistrant.spec.js
to cover line 343.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now! 💯
Description
Students are submitting ERT forms with campuses that do not match the campus names in Infobase. This is because some browsers are auto-filling the campus data. The UI only validates when the user changes the field. So this bad data gets submitted.
Changes I made