Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Date format fix #845

Merged
merged 5 commits into from
Sep 19, 2023
Merged

Date format fix #845

merged 5 commits into from
Sep 19, 2023

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Sep 12, 2023

Description

The Graduation date question displays the entire date/timestamp from the API when looking at past registrations. When displaying the dates, format them to make them more readable.

Changes made

  • Removed logic around formatting the initial date when loading a date picker. The full date/timestamp is fine. Each datepicker formats the displayed date based on what kind of question it is.
  • Formatted the dates in a readable format when they are displayed throughout the ERT.
  • Added new tests to check the initialDate

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need a write multiple tests and maybe multiple test pages for this change since it affects a lot of functionality.

app/scripts/directives/datepicker.js Outdated Show resolved Hide resolved
@caleballdrin
Copy link
Contributor Author

@dr-bizz I reorganized some of the tests to make them more clear. Are these enough tests? What other things should I test?

app/scripts/directives/datepicker.js Outdated Show resolved Hide resolved
test/spec/directives/datepicker.spec.js Show resolved Hide resolved
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Can you push this to the stage and let me know when you have so we can test it there before it goes live?

@caleballdrin
Copy link
Contributor Author

@dr-bizz i put it on staging yesterday. So you can test whenever.

@caleballdrin caleballdrin merged commit 02e0057 into master Sep 19, 2023
14 checks passed
@caleballdrin caleballdrin deleted the date-format-fix branch September 19, 2023 17:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants