Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Graduation date question and saving questions validation #842

Merged
merged 5 commits into from
Sep 7, 2023
Merged

Fix Graduation date question and saving questions validation #842

merged 5 commits into from
Sep 7, 2023

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Sep 7, 2023 •
edited
Loading

Description

Changes I've made

  • On initialization of the graduation date question, format the value that we get from the API
  • Check to see if questions are invalid before pushing them to the database.

@caleballdrin caleballdrin changed the title Fix Graduation date question and email question Fix Graduation date question Sep 7, 2023
wrandall22
wrandall22 reviewed Sep 7, 2023
View reviewed changes
Copy link
Contributor

@wrandall22 wrandall22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure I understand how using the 10th instead of the 1st helps fix the problem. Is this due to time zone issues? Is the 10th an arbitrary day of the month that is not used for anything but required by the API?

app/scripts/directives/datepicker.js Outdated Show resolved Hide resolved
@caleballdrin
Copy link
Contributor Author

@wrandall22 It doesn't matter what the day is, the API just needs a day. The time and timezone are set to 0 by the API. When I bring the data back in from the API and format it again, the datepicker sets it to the previous month. So I changed it to 10.

@caleballdrin caleballdrin added the On Staging Will be merged to the staging branch by Github Actions label Sep 7, 2023
@caleballdrin caleballdrin changed the title Fix Graduation date question Fix Graduation date question and saving questions validation Sep 7, 2023
@caleballdrin caleballdrin merged commit 0db31d8 into master Sep 7, 2023
13 checks passed
@caleballdrin caleballdrin deleted the fix-email-save branch September 7, 2023 21:19
dr-bizz added a commit that referenced this pull request Sep 8, 2023
@dr-bizz
Revert "Fix Graduation date question and saving questions validation (#…
32dea52 
…842)"

This reverts commit 0db31d8.
dr-bizz added a commit that referenced this pull request Sep 8, 2023
@dr-bizz
Revert "Fix Graduation date question and saving questions validation (#…
877ca1e 
…842)" (#843)

This reverts commit 0db31d8.
dr-bizz added a commit that referenced this pull request Sep 8, 2023
@dr-bizz
Reimplementing the reverted PR #842/#843 but not included changes wer…
a1fb5ec 
…e localModel is set. I'm confused to why we need to format scope.localModel differently.
@dr-bizz dr-bizz mentioned this pull request Sep 8, 2023
Merged
dr-bizz added a commit that referenced this pull request Sep 8, 2023
@dr-bizz
Reimplementing the reverted PR #842/#843 but not included changes wer…
71a7b48 
…e localModel is set. I'm confused to why we need to format scope.localModel differently. (#844)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wrandall22 wrandall22 wrandall22 approved these changes

@dr-bizz dr-bizz Awaiting requested review from dr-bizz

Assignees
No one assigned
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@caleballdrin @wrandall22