Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A recent deployment broke some code on the event details page, result… #839

Merged
merged 3 commits into from
Aug 14, 2023

Conversation

dr-bizz
Copy link
Contributor

@dr-bizz dr-bizz commented Aug 14, 2023

Description

A recent deployment broke some code on the event details page, resulting in the Associated Registrant Types no longer showing. This fix adds back the code which was removed.

Changes

  • Adding back code which was there previously. Ensuring name and selected are defined on types in the allowedRegistrantTypeSet array.

Deployment which had breaking changes #835

…ing in the Associated Registrant Types no longer showing. This fix adds back the code which was removed.
@dr-bizz dr-bizz added the On Staging Will be merged to the staging branch by Github Actions label Aug 14, 2023
@wrandall22
Copy link
Contributor

Does this break the liability form again, which is why Caleb removed it?

@dr-bizz
Copy link
Contributor Author

dr-bizz commented Aug 14, 2023

Looks like there is an error

…eing sent to the API. properties were causing errors.
@dr-bizz
Copy link
Contributor Author

dr-bizz commented Aug 14, 2023

Fixed the error which Caleb described.

@dr-bizz dr-bizz merged commit 1159125 into master Aug 14, 2023
13 checks passed
@dr-bizz dr-bizz deleted the fixing-breaking-change-to-associated-reg-types branch August 14, 2023 21:08
caleballdrin pushed a commit that referenced this pull request Aug 15, 2023
#839)

* A recent deployment broke some code on the event details page, resulting in the Associated Registrant Types no longer showing. This fix adds back the code which was removed.

* Had to remove unwanted properties from the conference copied object, which is being sent to the API. properties were causing errors.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants