Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVENT-826 New Profile Questions #838

Merged
merged 23 commits into from
Aug 16, 2023
Merged

EVENT-826 New Profile Questions #838

merged 23 commits into from
Aug 16, 2023

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Aug 8, 2023

Description

Adding 3 new profile questions:

Expected Graduation Date
https://jira.cru.org/browse/EVENT-826

  • New question that can be added to the top of the Questions page "Graduation Date"
  • The quesiton can then be dragged into place and tagged as a Cru Profile Question.
  • Question Default Title: "Expected Graduation Year (month & year)"
  • Question should be a drop down for month/year.

Ethnicity
https://jira.cru.org/browse/EVENT-827

  • New question that can be added to the top of the Questions page "Racial/Ethnic Identity"
  • The quesiton can then be dragged into place and tagged as a Cru Profile Question.
  • Question Default Title: "Racial/Ethnic Identity"
  • Question can be considered a "Checkbox" "Multiple Choice" question so that multiple options one option can be selected from the options
  • The custom "Other" Option does need to be on by default in the ERT but if it could be added for this default question that would be desired.

Cru Opportunities
https://jira.cru.org/browse/EVENT-828

  • New question that can be added to the top of the Questions page "Cru Opportunities"
  • The quesiton can then be dragged into place and tagged as a Cru Profile Question.
  • Question Default Title: "Would you like to be informed about new opportunities (like conferences, mission trips, career opportunities, etc.) to be involved with Cru around the U.S. & world? Checking yes below will add you to a subscription list to receive monthly updates on the latest Cru opportunities! You can unsubscribe at any time."
  • Question can be considered a "Multiple Choice" quesiton and expect one answer

Changes I've made

  • Added 3 new profile questions
  • Modified date picker to show the graduation date picker in a different format
  • Copied the radioQuestion to make ethnicityQuestion
  • Add the 3 profile questions as possible rules

Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is looking good. I have a few comments.

app/views/blocks/ethnicityQuestion.html Outdated Show resolved Hide resolved
app/scripts/directives/datepicker.js Outdated Show resolved Hide resolved
app/scripts/directives/datepicker.js Outdated Show resolved Hide resolved
app/scripts/directives/rule.js Show resolved Hide resolved
app/scripts/directives/blocks.js Show resolved Hide resolved
app/scripts/directives/blocks.js Show resolved Hide resolved
app/scripts/directives/blocks.js Show resolved Hide resolved
app/views/blocks/graduationDateQuestion.html Outdated Show resolved Hide resolved
app/views/blocks/opportunitiesQuestion.html Show resolved Hide resolved
dr-bizz
dr-bizz previously approved these changes Aug 11, 2023
Copy link
Contributor

@dr-bizz dr-bizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work on this!

caleballdrin and others added 7 commits August 15, 2023 12:09
#839)

* A recent deployment broke some code on the event details page, resulting in the Associated Registrant Types no longer showing. This fix adds back the code which was removed.

* Had to remove unwanted properties from the conference copied object, which is being sent to the API. properties were causing errors.
Make the Campus Profile question require a predefined selection
@dr-bizz dr-bizz self-requested a review August 16, 2023 19:10
@dr-bizz dr-bizz dismissed their stale review August 16, 2023 19:15

Need to review as you've added new changes

@caleballdrin caleballdrin merged commit 5a12dd5 into master Aug 16, 2023
13 checks passed
@caleballdrin caleballdrin deleted the new-profile-questions branch August 16, 2023 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants