-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
EVENT-825 Campus Question Force Selection Option #837
Conversation
In the description, it mentions adding an additional checkbox Option on the admin panel that would “Force Selection from Cru Database”. I can't see that in this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good. There seems to be a few things missing on this PR.
The text added to the field when used. (I've mentioned this in another comment).
There isn't a checkbox on the admin panel to allow the admin to Force Selection from Cru Database
It's worth making the campus dropdown have a |
I was looking into setting max-height and came across this issue. Maybe we should just limit the results to 10 from the API. |
Seems like there is a way but you have to make it work - ng-bootstrap/ng-bootstrap#1119 (comment). |
Add Event Type dropdown menu
Replace Gender with Sex and add tests to Profile Questions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great work!
Make the Campus Profile question require a predefined selection
Description
https://jira.cru.org/browse/EVENT-825
With the Salesforce integration we need to encourage the use of the Cru Profile questions to ensure better data and ensure our constituents are known by Cru. The Current "Campus" default question pulls from a database of Campuses but does require the registrant to select anything on the drop down list. This leads to inconsistent data as the same school could be represented in many ways with unlimited free form response.
The proposed improvement is as follows:
Update the default name when the question is used: "Campus- Type the full name of your campus and choose from the list that appears”
Changes I made
Companion PR https://github.com/CruGlobal/ert-api/pull/1030