Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EVENT-822 Change Gender to Sex #836

Merged
merged 5 commits into from
Aug 7, 2023
Merged

EVENT-822 Change Gender to Sex #836

merged 5 commits into from
Aug 7, 2023

Conversation

caleballdrin
Copy link
Contributor

@caleballdrin caleballdrin commented Jul 26, 2023

Description

https://jira.cru.org/browse/EVENT-822

With the Salesforce integration we need to encourage the use of the Cru Profile questions to ensure better data and ensure our constituents are known by Cru. With the release of the Cru Compassionate and Faithful material we have discussed with the cru theology team the need for an update to the current "Gender" Cru profile question so that we can continue to capture a binary "Male" "Female" answer.

The current Cru Profile and default question needs to be updated from "Gender" to "Sex"

Changes made

  • Change UI strings
  • Add a conditional to replace GENDER with Sex in the error message when multiple blocks are selected as the 'Cru Profile'

@caleballdrin caleballdrin added the On Staging Will be merged to the staging branch by Github Actions label Jul 26, 2023
@hlbraddock
Copy link
Contributor

hlbraddock commented Jul 26, 2023

I give my informal approval, but will defer formal PR approval to @dr-bizz

app/scripts/directives/blockEditor.js Outdated Show resolved Hide resolved
app/scripts/directives/blockEditor.js Outdated Show resolved Hide resolved
app/scripts/directives/blockEditor.js Outdated Show resolved Hide resolved
app/scripts/directives/blockEditor.js Outdated Show resolved Hide resolved
app/scripts/directives/blockEditor.js Outdated Show resolved Hide resolved
@dr-bizz dr-bizz self-requested a review July 27, 2023 20:30
@caleballdrin caleballdrin merged commit 8be1641 into master Aug 7, 2023
13 checks passed
@caleballdrin caleballdrin deleted the gender-to-sex branch August 7, 2023 15:29
caleballdrin added a commit that referenced this pull request Aug 8, 2023
Replace Gender with Sex and add tests to Profile Questions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
On Staging Will be merged to the staging branch by Github Actions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants