GT-2455 provide a Scarlet.Builder extension method to force the default platform #2173
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #2173 +/- ##
==========================================
- Coverage 40.28% 40.23% -0.05%
==========================================
Files 384 388 +4
Lines 5702 5709 +7
Branches 1401 1403 +2
==========================================
Hits 2297 2297
- Misses 3082 3089 +7
Partials 323 323 ☔ View full report in Codecov by Sentry. |
frett
force-pushed
the
scarletJava8Detection
branch
from
7f5a59e
to
03de060
Compare
| @NonNull | ||
| @SuppressWarnings("MethodName") | ||
| static RuntimePlatform Default() { | ||
| return new RuntimePlatform.Default(); |
There was a problem hiding this comment.
RuntimePlatform is a Kotlin internal class in another library, we can still access it from Java to create the instance we need.
|
|
||
| import androidx.annotation.NonNull; | ||
|
|
||
| class RuntimePlatformInternals { |
There was a problem hiding this comment.
This is a package private Java class to hide it from the public API for library consumers
| @@ -0,0 +1,3 @@ | |||
| package com.tinder.scarlet.internal.utils | |||
|
|
|||
| internal fun defaultPlatform() = RuntimePlatformInternals.Default() | |||
There was a problem hiding this comment.
we wrap the package-private java RuntimePlatformInternals.Default() in an internal Kotlin function, this allows us to access it from other packages in this module without exposing it on the public API
| * https://github.com/Tinder/Scarlet/issues/235 | ||
| * https://issuetracker.google.com/issues/342419066 | ||
| */ | ||
| fun Scarlet.Builder.forceDefaultPlatform() = apply { platform = defaultPlatform() } |
There was a problem hiding this comment.
This is the only new thing exposed on the public API of this module
No description provided.