Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Websocket updates #44

Merged
merged 10 commits into from
Nov 10, 2020
Merged

Websocket updates #44

merged 10 commits into from
Nov 10, 2020

Conversation

The-EDev
Copy link
Member

@The-EDev The-EDev commented Nov 9, 2020 •
edited
Loading

This PR:

  • Documents websocket.h and adds websocket message structure illustration.
  • Cleans up a small problem with app.h documentation.
  • Adds support for non masked client messages. (closes Crow does not accept 0 MASK bit in websockets #43)
  • Adds functionality to send a ping message from the server.
  • Exposes methods to send Ping and Pong to the end-user.
  • Resets the internal header variable before every read. (fixing potential issues where read is run and no actual data is taken from the socket)
  • Adds a test for websockets. (Tests #21)
  • Implements ipkn#328 (fixing a potential crash when using SSL websockets).
  • Allows for Ping and Pong payloads to be larger than 127 bytes.

I apologize ahead of time for any typos I missed.

mrozigor
mrozigor reviewed Nov 9, 2020
View reviewed changes
include/crow/websocket.h Outdated Show resolved Hide resolved
@The-EDev
Ping and Pong messages shouldn't fail with messages larger than 127 b…
fab2640 
…ytes anymore

Has the added advantage of making the code look more consistent, while sacrificing some performance (very little though)
@The-EDev
bump version in doc
5150fcd
@The-EDev The-EDev merged commit 515fa68 into master Nov 10, 2020
@The-EDev The-EDev deleted the websocket branch November 11, 2020 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mrozigor mrozigor mrozigor approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crow does not accept 0 MASK bit in websockets
2 participants
@The-EDev @mrozigor