Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2401

Merged
merged 5 commits into from
Oct 17, 2024
Merged

Fixes #2401

merged 5 commits into from
Oct 17, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Oct 17, 2024 •
edited
Loading

  • Fix events parsing
  • Fix Fairminter events rollback
  • Retry max 10 times on error -8
  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@adamkrellenstein adamkrellenstein changed the base branch from master to develop October 17, 2024 17:51
This was referenced Oct 17, 2024
Closed
Closed
@ouziel-slama ouziel-slama merged commit cc20c64 into develop Oct 17, 2024
11 of 14 checks passed
@ouziel-slama ouziel-slama deleted the fixes branch October 17, 2024 18:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouziel-slama @adamkrellenstein @Ouziel