Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2385

Merged
merged 6 commits into from
Oct 17, 2024
Merged

Fixes #2385

merged 6 commits into from
Oct 17, 2024
+83 −6

Conversation

ouziel-slama
Copy link
Contributor

  • Fix API v1 with Waitress
  • Replace "localhost" by "127.0.0.1" (to force IPv4)
  • Check API v1 on regtest
  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama merged commit 38e3d45 into develop Oct 17, 2024
16 of 17 checks passed
@ouziel-slama ouziel-slama deleted the fixes2 branch October 17, 2024 14:29
This was referenced Oct 17, 2024
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouziel-slama @adamkrellenstein @Ouziel