New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2384

Closed

ouziel-slama wants to merge 5 commits into develop from fixes

Contributor

ouziel-slama commented Oct 17, 2024 •

edited

Loading

Fix API v1 with Waitress
Replace "localhost" by "127.0.0.1" (to force IPv4)
Check API v1 on regtest

Double-check the spelling and grammar of all strings, code comments, etc.
Double-check that all code is deterministic that needs to be
Add tests to cover any new or revised logic
Ensure that the test suite passes
Update the project release notes
Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository


          Remove hop-by-hop header

1bc8da8

ouziel-slama marked this pull request as draft

October 17, 2024 13:04

Ouziel added 4 commits

October 17, 2024 13:13


          127.0.0.1 instead localhost


          use waitress for tests

db854c2


          check API v1 on regtest

0724ca3


          Add release notes

6104fe3

Contributor Author

ouziel-slama commented Oct 17, 2024

moved here https://github.com/CounterpartyXCP/counterparty-core/compare/develop...fixes2?expand=1

ouziel-slama closed this

ouziel-slama deleted the fixes branch

October 17, 2024 14:13

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet