v10.4.4 #2322
v10.4.4 #2322
Conversation
ouziel-slama
commented
Oct 9, 2024
•
ouziel-slama
commented
- Double-check the spelling and grammar of all strings, code comments, etc.
- Double-check that all code is deterministic that needs to be
- Add tests to cover any new or revised logic
- Ensure that the test suite passes
- Update the project release notes
- Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository
Properly handle invalid scripts in outputs
Bump version
Merge pull request #2308 from CounterpartyXCP/develop
Update release notes
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| else: | ||
| with start_sentry_span(op="cache.get") as sentry_get_span: | ||
| sentry_get_span.set_data("cache.key", cache_key) | ||
| if cache_key in BLOCK_CACHE: |
Check warning
Code scanning / pylint
Unnecessary "else" after "return", remove the "else" and de-indent the code inside it. Warning
|
|
||
|
|
||
| def is_server_ready(): | ||
| # TODO: find a way to mock this function for testing |
Check warning
Code scanning / pylint
TODO: find a way to mock this function for testing. Warning
|
|
||
| def refresh_current_block(db): | ||
| # update the current block index | ||
| global CURRENT_BLOCK_TIME # noqa F811 |
Check warning
Code scanning / pylint
Using the global statement. Warning
|
|
||
|
|
||
| def refresh_backend_height(db, start=False): | ||
| global BACKEND_HEIGHT, BACKEND_HEIGHT_TIMER # noqa F811 |
Check warning
Code scanning / pylint
Using the global statement. Warning
| refresh_backend_height(timer_db, start=True) | ||
| else: | ||
| refresh_current_block(timer_db) | ||
| global BACKEND_HEIGHT # noqa F811 |
Check warning
Code scanning / pylint
Using the global statement. Warning
| self.cfg.post_fork(self, worker) | ||
| worker.init_process() | ||
| sys.exit(0) | ||
| except SystemExit: |
Check warning
Code scanning / pylint
The except handler raises immediately. Warning
| self.log.debug("Exception while loading the application", exc_info=True) | ||
| sys.stderr.flush() | ||
| sys.exit(self.APP_LOAD_ERROR) | ||
| except Exception: |
Check warning
Code scanning / pylint
Catching too general exception Exception. Warning
| try: | ||
| worker.tmp.close() | ||
| self.cfg.worker_exit(self, worker) | ||
| except Exception: |
Check warning
Code scanning / pylint
Catching too general exception Exception. Warning
| pass | ||
|
|
||
|
|
||
| class GunicornApplication(gunicorn.app.base.BaseApplication): |
Check warning
Code scanning / pylint
Method 'init' is abstract in class 'BaseApplication' but is not overridden in child class 'GunicornApplication'. Warning
| class GunicornApplication(gunicorn.app.base.BaseApplication): | ||
| def __init__(self, app, args=None): | ||
| self.options = { | ||
| "bind": "%s:%s" % (config.API_HOST, config.API_PORT), |
Check warning
Code scanning / pylint
Formatting a regular string which could be an f-string. Warning
Merge pull request #2322 from CounterpartyXCP/develop
