Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #2318

Merged
merged 21 commits into from
Oct 9, 2024
Merged

Fixes #2318

merged 21 commits into from
Oct 9, 2024

Conversation

ouziel-slama
Copy link
Contributor

@ouziel-slama ouziel-slama commented Oct 8, 2024 •
edited
Loading

  • Fix last_block in get_running_info command
  • Enable Sentry Caches and Queries pages
  • Clean Gunicorn workers in regtest tests
  • Fix blockchain reorg
  • Add regtest test for reorg
  • Add regtest support in RSFetcher
  • Double-check the spelling and grammar of all strings, code comments, etc.
  • Double-check that all code is deterministic that needs to be
  • Add tests to cover any new or revised logic
  • Ensure that the test suite passes
  • Update the project release notes
  • Update the project documentation, as appropriate, with a corresponding Pull Request in the Documentation repository

@ouziel-slama ouziel-slama marked this pull request as draft October 8, 2024 06:40
@ouziel-slama ouziel-slama changed the title Bump Minimum Version to v10.4.4 for Block Index >= 866,000 Fixes Oct 8, 2024
@ouziel-slama ouziel-slama mentioned this pull request Oct 8, 2024
Closed
@ouziel-slama ouziel-slama mentioned this pull request Oct 8, 2024
Closed
6 tasks
@ouziel-slama ouziel-slama marked this pull request as ready for review October 8, 2024 09:11
github-advanced-security[bot]
github-advanced-security bot found potential problems Oct 8, 2024
View reviewed changes
counterparty-core/counterpartycore/lib/api/api_server.py
else:
with start_sentry_span(op="cache.get") as sentry_get_span:
sentry_get_span.set_data("cache.key", cache_key)
if cache_key in BLOCK_CACHE:

Check warning

Code scanning / pylint

Unnecessary "else" after "return", remove the "else" and de-indent the code inside it.

Unnecessary "else" after "return", remove the "else" and de-indent the code inside it.
@ouziel-slama ouziel-slama marked this pull request as draft October 8, 2024 19:57
@ouziel-slama ouziel-slama marked this pull request as ready for review October 9, 2024 14:35
@ouziel-slama ouziel-slama merged commit 36376aa into develop Oct 9, 2024
13 of 16 checks passed
@ouziel-slama ouziel-slama deleted the fixes branch October 9, 2024 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouziel-slama @adamkrellenstein @Ouziel