Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweaks #1538

Merged
merged 4 commits into from
Mar 20, 2024
Merged

Tweaks #1538

merged 4 commits into from
Mar 20, 2024

Conversation

ouziel-slama
Copy link
Contributor

Capture d’écran 2024-03-20 à 13 13 15

github-advanced-security[bot]
github-advanced-security bot found potential problems Mar 20, 2024
View reviewed changes
counterparty-lib/counterpartylib/server.py
if not no_confirm:
confirmation_message = colored('Continue? (y/N): ', "magenta")
if input(confirmation_message).lower() != 'y':
exit()

Check warning

Code scanning / pylint

Consider using 'sys.exit' instead. Warning

Consider using 'sys.exit' instead.
@ouziel-slama ouziel-slama changed the title Add Warning with Confirmation Dialogue to bootstrap Command Tweaks Mar 20, 2024
@ouziel-slama
Copy link
Contributor Author

ouziel-slama commented Mar 20, 2024 •
edited
Loading

  • Add Warning with Confirmation Dialogue to bootstrap Command
  • Update README with supported OS
  • Add --no-confirm flag for bootstrap

@adamkrellenstein
Copy link
Member

perfect!

@adamkrellenstein adamkrellenstein merged commit d231d69 into develop Mar 20, 2024
14 checks passed
@adamkrellenstein adamkrellenstein deleted the bootstrap branch March 20, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adamkrellenstein adamkrellenstein adamkrellenstein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ouziel-slama @adamkrellenstein @Ouziel