Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cc #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

cc #5

wants to merge 1 commit into from

Conversation

delthas
Copy link

@delthas delthas commented Jul 10, 2019

No description provided.

@Polochon-street
Copy link
Collaborator

Hi,

We are very happy about the interest you put in our coucouing project.
However, each PR needs a proper description, in order to help us understand how it will allow for more coucou. Also, a test would be nice :)

@delthas
Copy link
Author

delthas commented Jul 11, 2019

Hi,
Thanks for your quick answer. I simply used the same format as #3 but can provide more context!

cc allows for more coucou as per langue française.

As for tests: here is a simple test that can be run in a POSIX shell. First, install curl and pup. Then, run in your shell:

curl -s https://fr.wiktionary.org/wiki/cc | pup 'li:parent-of(span#langage_SMS) text{}' | tr -d '\n' | xargs -0 printf 'Signification de cc: %s\n'

This test will return the current meaning of "cc".

@c-cube
Copy link
Contributor

c-cube commented Jul 11, 2019

Note that our CLA (coucou license agreement) requires you to join the holy IRC channel and 👋.

@antoinepouille
Copy link

LGTM 👍

@Polochon-street
Copy link
Collaborator

@antoinepouille strong 👎 until the tests haven't been written out somewhere

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants