fix: RPC starkNet_executeTxn storing in-correct state data if the params calls is not an array

[khanti42]

PR Description:

This PR addresses the following changes:

1. Fixture Update:

   • The callsExamples.json fixture has been updated to handle both cases where calls can be either an array or a single object. This ensures that the test scenarios are consistent with the real-world behavior where calls might be in different formats.

   Changes:

   • Previously, calls were always treated as an array. The second example in the fixture now provides calls as a single object, allowing the tests to cover this scenario.

2. Test Enhancements:

   • Refactored the executeTxn.test.ts tests to use it.each to handle both cases where calls could be either an array or a single object.
   • This approach simplifies the test by parameterizing both cases (Call[] and Call), ensuring that the code is properly tested for different scenarios without duplicating test logic.

   Changes:

   • The previous test for executeTxn has been replaced with an it.each block, covering both the array and object formats of calls.
   • The test correctly asserts that the transaction execution behaves as expected, regardless of the format of calls.

3. Code Improvement:

   • The executeTxn.ts logic was updated to handle both array and non-array formats for calls.
   • A new variable call was introduced to check if calls is an array and, if so, uses the first element; otherwise, it directly uses the object. This avoids potential issues when calls is not an array.

   Changes:

   • The line calls[0] in the addTransaction method was replaced with the newly created call variable, ensuring correct handling of both formats.

Summary:

This PR ensures that both the code and tests properly handle calls when it is an array or a single object, improving robustness and coverage in different scenarios.

[sonarcloud]

Quality Gate passed for 'consensys_starknet-snap-wallet-ui'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[sonarcloud]

Quality Gate passed for 'consensys_starknet-snap-starknet-snap'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
37.9% Duplication on New Code

See analysis details on SonarCloud

[stanleyyconsensys]

LGTM, thank you very much for the update