chore: ensure backward compatibility with remoteEntry.js of snap v2.9.0 #355
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Stanley Yuen <[email protected]>
Co-authored-by: Stanley Yuen <[email protected]>
Co-authored-by: Stanley Yuen <[email protected]>
Co-authored-by: Stanley Yuen <[email protected]>
Co-authored-by: Stanley Yuen <[email protected]>
Co-authored-by: Stanley Yuen <[email protected]>
khanti42
requested review from
Julink-eth and
wantedsystem
and removed request for
a team
stanleyyconsensys
approved these changes
Sep 19, 2024
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description:
Backward Compatibility for Request Parameters
This PR ensures backward compatibility with version 2.9.0 for StarkNet-related methods (
starknet_sign*,starknet_execute, andstarknet_declare).signerAddresstoaddressmapping: In older versions,starknet_sign*methods used thesignerAddressfield. This update ensures that ifsignerAddressis passed in the request, it is mapped to theaddressfield required by the new version.senderAddresstoaddressmapping: Similarly, forstarknet_executeandstarknet_declare, which previously usedsenderAddress, the PR adds logic to map this toaddress.By handling both
signerAddressandsenderAddress, this update allows for smooth transitions to the new parameter structure without breaking existing integrations.