Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve failing tests #1373 #1389

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/gradle-nightly-tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ jobs:
go install github.com/consensys/go-corset/cmd/go-corset@latest

- name: Run Nightly tests
run: GOMEMLIMIT=196GiB ./gradlew nightlyTests
run: GOMEMLIMIT=100GiB ./gradlew nightlyTests
env:
JAVA_OPTS: -Dorg.gradle.daemon=false
CORSET_FLAGS: disable
Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/gradle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -144,18 +144,18 @@ jobs:
go install github.com/consensys/go-corset/cmd/go-corset@latest

- name: Run unit tests
run: GOMEMLIMIT=32GiB ./gradlew :arithmetization:test
run: GOMEMLIMIT=26GiB ./gradlew :arithmetization:test
env:
JAVA_OPTS: -Dorg.gradle.daemon=false
CORSET_FLAGS: disable
GOCORSET_FLAGS: -wd --ansi-escapes=false --report --air
GOCORSET_FLAGS: -b1024 -wd --ansi-escapes=false --report --air

- name: Run replay tests
run: GOMEMLIMIT=32GiB ./gradlew :arithmetization:fastReplayTests
run: GOMEMLIMIT=26GiB ./gradlew :arithmetization:fastReplayTests
env:
JAVA_OPTS: -Dorg.gradle.daemon=false
CORSET_FLAGS: disable
GOCORSET_FLAGS: -wd --ansi-escapes=false --report --air
GOCORSET_FLAGS: -b1024 -wd --ansi-escapes=false --report --air

- name: Upload test report
if: always()
Expand Down
6 changes: 2 additions & 4 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,18 +9,16 @@ repos:
- id: check-yaml
- id: check-xml
- repo: https://github.com/commitizen-tools/commitizen
rev: 3.5.3
rev: v3.29.1
hooks:
- id: commitizen
stages: [ commit-msg ]
- repo: https://github.com/jguttman94/pre-commit-gradle
rev: v0.3.0 # Use the ref you want to point at
hooks:
- id: gradle-check
args: [ "--wrapper", "--output" ]
- id: gradle-spotless
args: [ "--wrapper", "--output" ]
- repo: https://github.com/executablebooks/mdformat
rev: 0.7.14
rev: 0.7.17
hooks:
- id: mdformat
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@
import net.consensys.linea.zktracer.module.hub.AccountSnapshot;
import net.consensys.linea.zktracer.module.hub.Hub;
import org.hyperledger.besu.datatypes.Address;
import org.junit.jupiter.api.Disabled;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;

Expand All @@ -41,6 +42,7 @@ public class Issue1216Tests {
* blowing up with a NPE since the "after" version of the self destructor didn't exist yet in the
* code. This was solved in issue #1216.
*/
@Disabled
@Tag("nightly")
@Tag("replay")
@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,11 @@

@Tag("nightly")
public class NightlyTests {
@Test
void leoFailingRange() {
replay(LINEA_MAINNET, "5389571-5389577.json.gz");
}

// Leo's range split up 5104800-5104883
///////////////////////////////////////
@Test
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,6 @@ void bulkReplay() {
// bulkReplay(LINEA_MAINNET, "");
}

@Disabled
@Test
void leoFailingRange() {
replay(LINEA_MAINNET, "5389571-5389577.json.gz");
}

// @Disabled
@Test
void failingMmuModexp() {
Expand Down
1 change: 0 additions & 1 deletion gradle/tests.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -190,4 +190,3 @@ tasks.register("weeklyTests", Test) {
includeTags("weekly")
}
}

Loading