reconnect MMIO constraints #1388

letypequividelespoubelles · 2024-10-08T05:02:52Z

Partial debugging of reconnecting the MMIO constraints (inner + all lookup touching the MMIO)

Signed-off-by: Francois Bojarski <[email protected]>

…n trivil inst Signed-off-by: Francois Bojarski <[email protected]>

Signed-off-by: Francois Bojarski <[email protected]>

letypequividelespoubelles · 2024-10-10T13:11:10Z

...tization/src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/mmu/MmuCall.java

@@ -445,7 +445,7 @@ public static MmuCall forIdentityExtractCallData(
      final Hub hub, PrecompileSubsection precompileSubsection) {

    return new MmuCall(hub, MMU_INST_RAM_TO_RAM_SANS_PADDING)
-        .sourceId(precompileSubsection.callSection.hubStamp())


this and following are real fixes

letypequividelespoubelles · 2024-10-10T13:11:21Z

...tization/src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/mmu/MmuCall.java

          .sourceRamBytes(Optional.of(modexpSubsection.callerMemorySnapshot))
          .targetId(modexpSubsection.exoModuleOperationId())
-          .exoBytes(Optional.of(modExpMetadata.base()))
+          .exoBytes(Optional.of(leftPadTo(modExpMetadata.base(), MODEXP_COMPONENT_BYTE_SIZE)))


real fix too

Is modExpMetadata.base() also right padded (for short call data) ?

letypequividelespoubelles · 2024-10-10T13:11:45Z

.../src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/mmu/opcode/CodeCopy.java

@@ -38,7 +38,7 @@ public CodeCopy(final Hub hub) {
    this.hub = hub;
    this.contract = hub.currentFrame().metadata();

-    this.exoBytes(Optional.of(hub.romLex().getCodeByMetadata(contract)))


equivalent, but requires less computation

letypequividelespoubelles · 2024-10-10T13:12:01Z

.../consensys/linea/zktracer/module/hub/section/call/precompileSubsection/ModexpSubsection.java

@@ -60,17 +60,17 @@ public ModexpSubsection(final Hub hub, final CallSection callSection) {
    if (modexpMetaData
                .bbs()
                .toUnsignedBigInteger()
-                .compareTo(BigInteger.valueOf(PROVER_MAX_INPUT_BYTE_SIZE))
+                .compareTo(BigInteger.valueOf(MODEXP_COMPONENT_BYTE_SIZE))


we had a duplicate for this constant

letypequividelespoubelles · 2024-10-10T13:12:22Z

...tion/src/main/java/net/consensys/linea/zktracer/module/hub/section/copy/CodeCopySection.java

-            warmth,
-            hub.deploymentNumberOf(codeAddress),
-            hub.deploymentStatusOf(codeAddress));
+        AccountSnapshot.canonical(hub, hub.messageFrame().getContractAddress());


not a fix, just use the canonical way when possible

letypequividelespoubelles · 2024-10-10T13:12:34Z

arithmetization/src/main/java/net/consensys/linea/zktracer/module/mmio/Mmio.java

@@ -87,26 +87,23 @@ public void commit(List<MappedByteBuffer> buffers) {
    Trace trace = new Trace(buffers);
    int stamp = 0;
    for (MmuOperation mmuOperation : mmu.operations().getAll()) {
-      if (mmuOperation.traceMe()) {


letypequividelespoubelles · 2024-10-10T13:12:45Z

arithmetization/src/main/java/net/consensys/linea/zktracer/module/mmu/Mmu.java

@@ -59,14 +59,10 @@ public void commit(List<MappedByteBuffer> buffers) {

    for (MmuOperation mmuOperation : operations.getAll()) {
      Preconditions.checkState(mmuOperation.traceMe(), "Cannot compute if traceMe is false");
-      if (mmuOperation.traceMe()) {


letypequividelespoubelles · 2024-10-10T13:13:03Z

arithmetization/src/main/java/net/consensys/linea/zktracer/module/mmu/MmuOperation.java

-        final int sizeToExtract = mmioInst.size() == 0 ? LLARGE : mmioInst.size();
-        final Bytes16 exoLimb = readBytes(mmuData.exoBytes(), offset, sizeToExtract);
-        mmioInst.limb(exoLimb);
+      for (MmuToMmioInstruction mmioInst : mmuData.mmuToMmioInstructions()) {


this is a fix

letypequividelespoubelles · 2024-10-10T13:13:19Z

...etization/src/main/java/net/consensys/linea/zktracer/module/mmu/instructions/ModexpData.java

@@ -263,7 +263,9 @@ public MmuData setMicroInstructions(MmuData mmuData) {
      middleMicroInstruction(mmuData, sourceLimbOffset, targetLimbOffset);
    }

-    lastMicroInstruction(mmuData);
+    if (initialTotalNonTrivial > 1) {


this is a fix

letypequividelespoubelles · 2024-10-10T13:13:34Z

arithmetization/src/main/java/net/consensys/linea/zktracer/types/Bytecodes.java

 import org.apache.tuweni.bytes.Bytes;

 public class Bytecodes {

-  public static Bytes16 readBytes(final Bytes data, final long offset, final int sizeToRead) {
-    if (offset >= data.size()) {
+  public static Bytes16 readBytes(


this is a fix

letypequividelespoubelles · 2024-10-10T13:14:04Z

linea-constraints

just update to the latest master. MMIO constraints are still not plugged

OlivierBBB · 2024-10-11T09:35:13Z

...tization/src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/mmu/MmuCall.java

@@ -445,7 +445,7 @@ public static MmuCall forIdentityExtractCallData(
      final Hub hub, PrecompileSubsection precompileSubsection) {

    return new MmuCall(hub, MMU_INST_RAM_TO_RAM_SANS_PADDING)
-        .sourceId(precompileSubsection.callSection.hubStamp())
+        .sourceId(hub.currentFrame().contextNumber()) // called at ContextReEntry


OlivierBBB · 2024-10-11T09:36:02Z

...tization/src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/mmu/MmuCall.java

@@ -706,10 +706,10 @@ public static MmuCall forModexpExtractBase(
      final Hub hub, final ModexpSubsection modexpSubsection, final ModexpMetadata modExpMetadata) {
    if (modExpMetadata.extractBase()) {
      return new MmuCall(hub, MMU_INST_MODEXP_DATA)
-          .sourceId(modexpSubsection.callSection.hubStamp())
+          .sourceId(hub.currentFrame().contextNumber()) // called at ContextReEntry


OlivierBBB

I still have to understand the changes labeled with ⭐, could you please give a short description of the intended effect ?

OlivierBBB · 2024-10-11T12:31:18Z

...tization/src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/mmu/MmuCall.java

          .sourceRamBytes(Optional.of(modexpSubsection.callerMemorySnapshot))
          .targetId(modexpSubsection.exoModuleOperationId())
-          .exoBytes(Optional.of(modExpMetadata.base()))
+          .exoBytes(Optional.of(leftPadTo(modExpMetadata.base(), MODEXP_COMPONENT_BYTE_SIZE)))


Is modExpMetadata.base() also right padded (for short call data) ?

OlivierBBB · 2024-10-11T12:31:49Z

.../src/main/java/net/consensys/linea/zktracer/module/hub/fragment/imc/mmu/opcode/CodeCopy.java

@@ -38,7 +38,7 @@ public CodeCopy(final Hub hub) {
    this.hub = hub;
    this.contract = hub.currentFrame().metadata();

-    this.exoBytes(Optional.of(hub.romLex().getCodeByMetadata(contract)))
+    this.exoBytes(Optional.of(hub.currentFrame().code().bytecode()))


OlivierBBB · 2024-10-11T12:36:05Z

arithmetization/src/main/java/net/consensys/linea/zktracer/types/Bytecodes.java

 import org.apache.tuweni.bytes.Bytes;

 public class Bytecodes {

-  public static Bytes16 readBytes(final Bytes data, final long offset, final int sizeToRead) {
-    if (offset >= data.size()) {
+  public static Bytes16 readBytes(


OlivierBBB · 2024-10-11T12:36:18Z

...etization/src/main/java/net/consensys/linea/zktracer/module/mmu/instructions/ModexpData.java

@@ -263,7 +263,9 @@ public MmuData setMicroInstructions(MmuData mmuData) {
      middleMicroInstruction(mmuData, sourceLimbOffset, targetLimbOffset);
    }

-    lastMicroInstruction(mmuData);
+    if (initialTotalNonTrivial > 1) {


OlivierBBB · 2024-10-11T12:37:02Z

arithmetization/src/main/java/net/consensys/linea/zktracer/module/mmu/MmuOperation.java

-        final int sizeToExtract = mmioInst.size() == 0 ? LLARGE : mmioInst.size();
-        final Bytes16 exoLimb = readBytes(mmuData.exoBytes(), offset, sizeToExtract);
-        mmioInst.limb(exoLimb);
+      for (MmuToMmioInstruction mmioInst : mmuData.mmuToMmioInstructions()) {


reconnect MMIO constraints

0eb9cac

Signed-off-by: Francois Bojarski <[email protected]>

letypequividelespoubelles linked an issue Oct 8, 2024 that may be closed by this pull request

Re-connect RAM (MMU/MMIO) #917

Open

letypequividelespoubelles self-assigned this Oct 8, 2024

letypequividelespoubelles added the debugging label Oct 8, 2024

letypequividelespoubelles and others added 12 commits October 8, 2024 12:23

cleaning + fix too much MMIO inst for modexp data if only one MMIO no…

d2911d0

…n trivil inst Signed-off-by: Francois Bojarski <[email protected]>

fix no limb for limb vanishes instruction

6efb519

Signed-off-by: Francois Bojarski <[email protected]>

fix lookup mmio -> BLKMDXP

03f2e2b

Signed-off-by: Francois Bojarski <[email protected]>

Merge branch 'arith-dev' into feat/issue-917/reconnect-ram

fe4276b

clean: kill duplicate constant

1297355

Signed-off-by: Francois Bojarski <[email protected]>

fix source CN to extract arg for modexp

733c301

Signed-off-by: Francois Bojarski <[email protected]>

fix: generating the limb needs to know TBO

039aeb9

Signed-off-by: Francois Bojarski <[email protected]>

Merge branch 'arith-dev' into feat/issue-917/reconnect-ram

558fc9f

fix source Id for Identity PRC MMU call

c32a012

Signed-off-by: Francois Bojarski <[email protected]>

fix (again) reading exo Bytes

8e4568b

Signed-off-by: Francois Bojarski <[email protected]>

Merge branch 'arith-dev' into feat/issue-917/reconnect-ram

f2a4d0f

some more fixes

3037ade

Signed-off-by: Francois Bojarski <[email protected]>

letypequividelespoubelles marked this pull request as ready for review October 10, 2024 13:09

Merge branch 'arith-dev' into feat/issue-917/reconnect-ram

4c4b39d

letypequividelespoubelles commented Oct 10, 2024

View reviewed changes

linea-constraints

Copy link

Collaborator Author

letypequividelespoubelles Oct 10, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just update to the latest master. MMIO constraints are still not plugged

OlivierBBB reviewed Oct 11, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reconnect MMIO constraints #1388

reconnect MMIO constraints #1388

letypequividelespoubelles commented Oct 8, 2024 •

edited

Loading

letypequividelespoubelles Oct 10, 2024

letypequividelespoubelles Oct 10, 2024

OlivierBBB Oct 11, 2024

letypequividelespoubelles Oct 10, 2024

letypequividelespoubelles Oct 10, 2024 •

edited

Loading

letypequividelespoubelles Oct 10, 2024

letypequividelespoubelles Oct 10, 2024

letypequividelespoubelles Oct 10, 2024

letypequividelespoubelles Oct 10, 2024

OlivierBBB Oct 11, 2024

letypequividelespoubelles Oct 10, 2024

OlivierBBB Oct 11, 2024

letypequividelespoubelles Oct 10, 2024

OlivierBBB Oct 11, 2024

letypequividelespoubelles Oct 10, 2024

OlivierBBB Oct 11, 2024 •

edited

Loading

OlivierBBB Oct 11, 2024

OlivierBBB left a comment

OlivierBBB Oct 11, 2024

OlivierBBB Oct 11, 2024

OlivierBBB Oct 11, 2024

OlivierBBB Oct 11, 2024

OlivierBBB Oct 11, 2024

reconnect MMIO constraints #1388

Are you sure you want to change the base?

reconnect MMIO constraints #1388

Conversation

letypequividelespoubelles commented Oct 8, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

letypequividelespoubelles Oct 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OlivierBBB Oct 11, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

OlivierBBB left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

letypequividelespoubelles commented Oct 8, 2024 •

edited

Loading

letypequividelespoubelles Oct 10, 2024 •

edited

Loading

OlivierBBB Oct 11, 2024 •

edited

Loading