Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(contracts): As an Issuer, I want to benefit from an improved NFTPortal #715

Draft
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

alainncls
Copy link
Collaborator

What does this PR do?

Adds more features to the NFTPortal

Related ticket

Fixes #714

Type of change

  • Chore
  • Bug fix
  • New feature
  • Documentation update

Check list

  • Unit tests for any smart contract change
  • Contracts and functions are documented

@alainncls alainncls self-assigned this Sep 4, 2024
@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2024

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 94.66%. Comparing base (e99f776) to head (5997aac).
Report is 28 commits behind head on dev.

Files with missing lines Patch % Lines
contracts/src/examples/portals/NFTPortal.sol 0.00% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #715      +/-   ##
==========================================
+ Coverage   92.07%   94.66%   +2.59%     
==========================================
  Files          30       31       +1     
  Lines         492      525      +33     
  Branches      112      123      +11     
==========================================
+ Hits          453      497      +44     
+ Misses         39       28      -11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alainncls alainncls force-pushed the feat/as-an-issuer-i-want-to-benefit-from-an-improved-nftportal branch 6 times, most recently from 8eed2dd to d9d2401 Compare September 11, 2024 15:56
@alainncls alainncls force-pushed the feat/as-an-issuer-i-want-to-benefit-from-an-improved-nftportal branch from d9d2401 to 5997aac Compare September 17, 2024 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[US] As an Issuer, I want to benefit from an improved NFTPortal
2 participants