Support Lookup Constraints #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This puts in place a rough layout for lookup constraints which looks like it will work. The next step is to update the parser and add some tests.
Lookups are now operational. Some current issues to be resolved: (1) cannot parse lookups involving different modules; (2) missing tests for lookups involving multiple columns on each side.
Expanded columns are those that arise from a lookup which involves an expression, rather than just a column access. These are now supported. As such, the only remaining component to implement is support for inter-module lookups.
This updates the parser to generate inter-module lookups. That is, qualified column accesses are permitted within a lookup (but nowhere else).
DavePearce
force-pushed
the
49-support-lookup-inclusion-constraints
branch
from
785543f
to
f26d1d2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for lookup constraints. At this stage, evaluation performance is something which can be improved.