Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: edge case where domain cardinality is 1 #454

Merged
merged 1 commit into from
Nov 14, 2023
Merged

fix: edge case where domain cardinality is 1 #454

merged 1 commit into from
Nov 14, 2023

Conversation

gbotrel
Copy link
Collaborator

@gbotrel gbotrel commented Oct 5, 2023

Description

Handle edge case that could cause a panic (trigger in gnark tests with plonk circuit with a single constraint).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

@gbotrel gbotrel added the bug Something isn't working label Oct 5, 2023
@github-actions
Copy link

github-actions bot commented Oct 5, 2023

Summary

✅ Passed: 5903
❌ Failed: 0
🚧 Skipped: 5

🚧 Skipped

  • TestReference (github.com/consensys/gnark-crypto/ecc/bn254/fr/sis)
  • TestLimbDecomposition (github.com/consensys/gnark-crypto/ecc/bn254/fr/sis)
  • TestAppend (github.com/consensys/gnark-crypto/ecc/bn254/fr/tensor-commitment)
  • TestAppendSis (github.com/consensys/gnark-crypto/ecc/bn254/fr/tensor-commitment)
  • TestCommitmentSis (github.com/consensys/gnark-crypto/ecc/bn254/fr/tensor-commitment)

@gbotrel gbotrel merged commit ef56c84 into master Nov 14, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasPiellard ThomasPiellard ThomasPiellard approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gbotrel @ThomasPiellard